github-actions[bot] commented on code in PR #18822:
URL: https://github.com/apache/doris/pull/18822#discussion_r1171194613


##########
be/src/olap/schema_change.cpp:
##########
@@ -1681,12 +1681,16 @@ Status SchemaChangeHandler::_parse_request(const 
SchemaChangeParams& sc_params,
             }
         }
 
-        int32_t column_index = base_tablet_schema->field_index(column_name);
+        int32_t column_index = 
base_tablet_schema->field_index(std::string_view(column_name));

Review Comment:
   warning: no matching member function for call to 'field_index' 
[clang-diagnostic-error]
   ```cpp
           int32_t column_index = 
base_tablet_schema->field_index(std::string_view(column_name));
                                                      ^
   ```
   **be/src/olap/tablet_schema.h:187:** candidate function not viable: no known 
conversion from 'std::string_view' (aka 'basic_string_view<char>') to 'const 
std::string' (aka 'const basic_string<char>') for 1st argument
   ```cpp
       int32_t field_index(const std::string& field_name) const;
               ^
   ```
   **be/src/olap/tablet_schema.h:188:** candidate function not viable: no known 
conversion from 'std::string_view' (aka 'basic_string_view<char>') to 'int32_t' 
(aka 'int') for 1st argument
   ```cpp
       int32_t field_index(int32_t col_unique_id) const;
               ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to