924060929 commented on code in PR #18863:
URL: https://github.com/apache/doris/pull/18863#discussion_r1172551986
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalProject.java:
##########
@@ -82,7 +83,10 @@ private LogicalProject(List<NamedExpression> projects,
List<NamedExpression> exc
Optional<GroupExpression> groupExpression,
Optional<LogicalProperties> logicalProperties,
CHILD_TYPE child, boolean isDistinct) {
super(PlanType.LOGICAL_PROJECT, groupExpression, logicalProperties,
child);
- this.projects = ImmutableList.copyOf(Objects.requireNonNull(projects,
"projects can not be null"));
+ Preconditions.checkArgument(projects != null, "projects can not be
null");
+ this.projects = projects.isEmpty()
+ ?
ImmutableList.of(ExpressionUtils.selectMinimumColumn(child.getOutput()))
Review Comment:
child maybe unbound, so selectMinimumColumn() at this place could failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
