github-actions[bot] commented on code in PR #18874:
URL: https://github.com/apache/doris/pull/18874#discussion_r1174740626
##########
be/src/runtime/load_channel.cpp:
##########
@@ -84,6 +84,28 @@ Status LoadChannel::open(const PTabletWriterOpenRequest&
params) {
return Status::OK();
}
+Status LoadChannel::open_partition(const PartitionOpenRequest& params) {
Review Comment:
warning: out-of-line definition of 'open_partition' does not match any
declaration in 'doris::LoadChannel' [clang-diagnostic-error]
```cpp
Status LoadChannel::open_partition(const PartitionOpenRequest& params) {
^
```
##########
be/src/runtime/load_channel.cpp:
##########
@@ -84,6 +84,28 @@
return Status::OK();
}
+Status LoadChannel::open_partition(const PartitionOpenRequest& params) {
+ int64_t index_id = params.index_id();
+ std::shared_ptr<TabletsChannel> channel;
+ {
+ std::lock_guard<std::mutex> l(_lock);
+ auto it = _tablets_channels.find(index_id);
+ if (it != _tablets_channels.end()) {
+ channel = it->second;
+ } else {
+ // create a new tablets channel
+ TabletsChannelKey key(params.id(), index_id);
+ channel.reset(new TabletsChannel(key, _load_id,
_is_high_priority));
Review Comment:
warning: no matching constructor for initialization of
'doris::TabletsChannel' [clang-diagnostic-error]
```cpp
channel.reset(new TabletsChannel(key, _load_id,
_is_high_priority));
^
```
**be/src/runtime/tablets_channel.h:83:** candidate constructor not viable:
requires 4 arguments, but 3 were provided
```cpp
TabletsChannel(const TabletsChannelKey& key, const UniqueId& load_id,
bool is_high_priority,
^
```
**be/src/runtime/tablets_channel.h:81:** candidate constructor (the implicit
copy constructor) not viable: requires 1 argument, but 3 were provided
```cpp
class TabletsChannel {
^
```
##########
be/src/runtime/load_channel.h:
##########
@@ -56,6 +56,8 @@ class LoadChannel {
// open a new load channel if not exist
Status open(const PTabletWriterOpenRequest& request);
+ Status open_partition(const PartitionOpenRequest& params);
Review Comment:
warning: unknown type name 'PartitionOpenRequest' [clang-diagnostic-error]
```cpp
Status open_partition(const PartitionOpenRequest& params);
^
```
##########
be/src/runtime/tablets_channel.h:
##########
@@ -87,6 +87,9 @@ class TabletsChannel {
~TabletsChannel();
Status open(const PTabletWriterOpenRequest& request);
+
+ // Open specific partition all writers
+ Status open_all_writers_for_partition(const PartitionOpenRequest& request);
Review Comment:
warning: unknown type name 'PartitionOpenRequest' [clang-diagnostic-error]
```cpp
Status open_all_writers_for_partition(const PartitionOpenRequest&
request);
^
```
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -54,6 +54,8 @@ class LoadChannelMgr {
// open a new load channel if not exist
Status open(const PTabletWriterOpenRequest& request);
+ Status open_partition(const PartitionOpenRequest& params);
Review Comment:
warning: unknown type name 'PartitionOpenRequest' [clang-diagnostic-error]
```cpp
Status open_partition(const PartitionOpenRequest& params);
^
```
##########
be/src/runtime/load_channel_mgr.cpp:
##########
@@ -134,6 +134,21 @@ Status LoadChannelMgr::open(const
PTabletWriterOpenRequest& params) {
return Status::OK();
}
+Status LoadChannelMgr::open_partition(const PartitionOpenRequest& params) {
Review Comment:
warning: out-of-line definition of 'open_partition' does not match any
declaration in 'doris::LoadChannelMgr' [clang-diagnostic-error]
```cpp
Status LoadChannelMgr::open_partition(const PartitionOpenRequest& params) {
^
```
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -319,6 +392,57 @@ Status TabletsChannel::_open_all_writers(const
PTabletWriterOpenRequest& request
return Status::OK();
}
+Status TabletsChannel::open_all_writers_for_partition(const
PartitionOpenRequest& request) {
Review Comment:
warning: out-of-line definition of 'open_all_writers_for_partition' does not
match any declaration in 'doris::TabletsChannel' [clang-diagnostic-error]
```cpp
Status TabletsChannel::open_all_writers_for_partition(const
PartitionOpenRequest& request) {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
