github-actions[bot] commented on code in PR #17793:
URL: https://github.com/apache/doris/pull/17793#discussion_r1174852713
##########
be/src/vec/aggregate_functions/aggregate_function_quantile_state.cpp:
##########
@@ -20,25 +20,22 @@
#include <algorithm>
#include "vec/aggregate_functions//aggregate_function_simple_factory.h"
+#include "vec/aggregate_functions/helpers.h"
#include "vec/data_types/data_type.h"
namespace doris::vectorized {
AggregateFunctionPtr create_aggregate_function_quantile_state_union(const
std::string& name,
const
DataTypes& argument_types,
const bool
result_is_nullable) {
- const bool arg_is_nullable = argument_types[0]->is_nullable();
- if (arg_is_nullable) {
- return std::make_shared<AggregateFunctionQuantileStateOp<
- true, AggregateFunctionQuantileStateUnionOp,
double>>(argument_types);
- } else {
- return std::make_shared<AggregateFunctionQuantileStateOp<
- false, AggregateFunctionQuantileStateUnionOp,
double>>(argument_types);
- }
+ return
AggregateFunctionPtr(creator_without_type::create<AggregateFunctionQuantileStateOp<
Review Comment:
warning: no matching function for call to 'create' [clang-diagnostic-error]
```cpp
return
AggregateFunctionPtr(creator_without_type::create<AggregateFunctionQuantileStateOp<
^
```
**be/src/vec/aggregate_functions/helpers.h:63:** candidate function template
not viable: no known conversion from 'const bool' to 'const
doris::vectorized::DataTypes' (aka 'const vector<shared_ptr<const
doris::vectorized::IDataType>>') for 1st argument
```cpp
static AggregateFunctionPtr create(const DataTypes& argument_types,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
