OK, thanks. I'll keep looking at the net code, and can improve it later.
On Fri, 20 Jul 2018 12:07:00 +0800 Sepherosa Ziehau <sepher...@gmail.com> wrote: > Well, I don't think if_alloc makes sense for Dfly. But if you have > already changed some code, then let it be. > > On Fri, Jul 20, 2018 at 11:19 AM, Aaron LI <a...@aaronly.me> wrote: > > On Fri, 20 Jul 2018 10:43:16 +0800 > > Sepherosa Ziehau <sepher...@gmail.com> wrote: > > > >> On Fri, Jul 20, 2018 at 10:19 AM, Aaron LI <a...@aaronly.me> wrote: > >> > On Fri, 20 Jul 2018 09:40:21 +0800 > >> > Sepherosa Ziehau <sepher...@gmail.com> wrote: > >> > > >> >> I am not quite sure why we want to use if_alloc() in the first > >> >> place? > >> > > >> > Since our if_alloc() is very simple, so there is no big benefit to use > >> > it over the direct kmalloc(). But if_alloc() is easier to use and more > >> > intuitive. > >> > >> I mean why allocate in the first place? What's wrong w/ embedding? > > > > There is nothing wrong with embedding ifnet inside tun_softc. > > > > So do you think is it better to embed or not embed the ifnet? I'll follow > > your advice. Thanks. > >
pgpQitKq0b_9i.pgp
Description: OpenPGP digital signature