This is an automated email from the ASF dual-hosted git repository. volodymyr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/drill.git
commit 21733b01a4275b508d65768a578070f633548095 Author: Kui LIU <brucekui...@gmail.com> AuthorDate: Mon Apr 30 08:43:00 2018 +0200 DRILL-6347: Change method names to "visitField". Further change the method names to "visitField" with Vlad Rozov's comments. closes #1236 --- .../planner/physical/visitor/PrelVisualizerVisitor.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java index 703d648..0ee685f 100644 --- a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java +++ b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java @@ -87,11 +87,11 @@ public class PrelVisualizerVisitor } - public void field(String label, boolean value) { - field(label, Boolean.toString(value)); + public void visitField(String label, boolean value) { + visitField(label, Boolean.toString(value)); } - private void field(String label, String value) { + private void visitField(String label, String value) { indent(); out.append(label) .append(" = ") @@ -99,10 +99,10 @@ public class PrelVisualizerVisitor .append("\n"); } - public void listField(String label, + public void visitField(String label, Object[] values) { if (values == null) { - field(label, "null"); + visitField(label, "null"); return; } StringBuilder buf = new StringBuilder(); @@ -120,7 +120,7 @@ public class PrelVisualizerVisitor } } buf.append("]"); - field(label, buf.toString()); + visitField(label, buf.toString()); } @Override @@ -156,8 +156,8 @@ public class PrelVisualizerVisitor private void visitBasePrel(Prel prel, VisualizationState value) { value.startNode(prel); - value.listField("encodings", prel.getSupportedEncodings()); - value.field("needsReorder", prel.needsFinalColumnReordering()); + value.visitField("encodings", prel.getSupportedEncodings()); + value.visitField("needsReorder", prel.needsFinalColumnReordering()); } private void endNode(Prel prel, VisualizationState value) throws Exception { -- To stop receiving notification emails like this one, please contact volody...@apache.org.