asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410530313 Hi, @jihoonson . Thanks for your comments. > Also, please move this and this to HttpClientPipelineFactory, so that we can put all channel pipeline initialization codes together. Yes, this change will init those channel pipelines more efficiently. However, this SSL handler may be designed for HTTPs requests, so it might not be reasonable if we move it to `HttpClientPipelineFactory`.. What do you think? > Regarding CauseMatcher, it sounds good to me. Please raise a new PR if you want to apply it to all possible use cases. Sure, I will create a new PR to improve them.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
