clintropolis commented on a change in pull request #6107: Order rows during
incremental index persist when rollup is disabled.
URL: https://github.com/apache/incubator-druid/pull/6107#discussion_r207749497
##########
File path:
processing/src/main/java/io/druid/segment/incremental/IncrementalIndex.java
##########
@@ -1379,10 +1407,31 @@ public long getMaxTimeMillis()
);
}
+ private Stream<IncrementalIndexRow> timeAndDimsOrderedConcat(
+ final Collection<Deque<IncrementalIndexRow>> rowGroups,
+ final boolean descending
+ )
+ {
+ if (descending) {
Review comment:
Oops, good point, my copy pasta is showing 🍝 :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
