jihoonson commented on a change in pull request #6090: Fix missing exception
handling as part of
`io.druid.java.util.http.client.netty.HttpClientPipelineFactory`
URL: https://github.com/apache/incubator-druid/pull/6090#discussion_r208428237
##########
File path:
java-util/src/main/java/io/druid/java/util/http/client/pool/ChannelResourceFactory.java
##########
@@ -109,6 +112,28 @@ public ChannelFuture generate(final String hostname)
final ChannelPipeline pipeline =
connectFuture.getChannel().getPipeline();
pipeline.addFirst("ssl", sslHandler);
+ pipeline.addLast("connectionErrorHandler", new
SimpleChannelUpstreamHandler()
+ {
+ private final Logger LOGGER = new
Logger(SimpleChannelUpstreamHandler.class);
Review comment:
It looks that we can set exceptions for `handshakeFuture` rather than
logging errors and this would be better because exceptions can be propagated to
the callers properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
