FaxianZhao opened a new pull request #6336: update insert pending segments logic to synchronous URL: https://github.com/apache/incubator-druid/pull/6336 I delete the branch about #6283 by mistake. So I can't modify that pull request. There are some comments. 1. Mysql default transaction isolation is REPEATABLE_READ, treat it as READ_COMMITTED will reduce insert id conflict. 2. My segments table is too big to select the overlaps segment items. Add an index to 'dataSource used end' is work well for the most of scenarios. It will speed up getting recently segments for select and insert. Add an index to 'dataSource used start' is a good idea, but I didn't include it in this patch. 3. I think 'select and insert' doesn't need within transaction. (Fix same issue with phase 1) 4. sync's performance is better than concurrent retry in my business.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
