jon-wei commented on a change in pull request #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657534
########## File path: server/src/main/java/org/apache/druid/client/TimelineServerView.java ########## @@ -36,6 +38,9 @@ @Nullable TimelineLookup<String, ServerSelector> getTimeline(DataSource dataSource); + @Nullable Review comment: Does this need to be nullable? None of the implementations return null. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
