jihoonson commented on a change in pull request #6396: Implement MapVirtualColumn.makeDimensionSelector properly URL: https://github.com/apache/incubator-druid/pull/6396#discussion_r221339164
########## File path: extensions-contrib/virtual-columns/src/main/java/org/apache/druid/segment/MapVirtualColumnDimensionSelector.java ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.druid.segment; + +import org.apache.druid.common.config.NullHandling; +import org.apache.druid.query.monomorphicprocessing.RuntimeShapeInspector; + +abstract class MapVirtualColumnDimensionSelector implements DimensionSelector +{ + private final DimensionSelector keySelector; + private final DimensionSelector valueSelector; + + MapVirtualColumnDimensionSelector( + DimensionSelector keySelector, + DimensionSelector valueSelector + ) + { + this.keySelector = keySelector; + this.valueSelector = valueSelector; + } + + protected DimensionSelector getKeySelector() + { + return keySelector; + } + + protected DimensionSelector getValueSelector() + { + return valueSelector; + } + + @Override + public double getDouble() + { + assert NullHandling.replaceWithDefault(); + return 0.0; Review comment: Sounds good. I think it would be a more general discussion about how to support `Map` type in Druid. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
