surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API
backwards compatible with 0.12 (#6333)
URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r221410391
##########
File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java
##########
@@ -22,18 +22,23 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.base.Preconditions;
+import org.apache.druid.java.util.common.logger.Logger;
import org.joda.time.DateTime;
import javax.annotation.Nullable;
import java.util.Objects;
public class TaskStatusPlus
{
+ private static final Logger log = new Logger(TaskStatusPlus.class);
+
private final String id;
private final String type;
private final DateTime createdTime;
private final DateTime queueInsertionTime;
- private final TaskState state;
+ private final TaskState statusCode;
+ @Deprecated
+ private final TaskState status;
Review comment:
I think both variables are required with `@JsonProperty`, else the
serialization/deserialization can fail. for eg if `status` is present in the
json, then deserialization fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
