surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221496251
##########
File path:
benchmarks/src/main/java/org/apache/druid/benchmark/query/SqlBenchmark.java
##########
@@ -111,16 +114,20 @@ public void setup()
.createQueryRunnerFactoryConglomerate();
final QueryRunnerFactoryConglomerate conglomerate =
conglomerateCloserPair.lhs;
final PlannerConfig plannerConfig = new PlannerConfig();
+ final DruidLeaderClient druidLeaderClient =
EasyMock.createMock(DruidLeaderClient.class);
this.walker = new
SpecificSegmentsQuerySegmentWalker(conglomerate).add(dataSegment, index);
plannerFactory = new PlannerFactory(
CalciteTests.createMockSchema(conglomerate, walker, plannerConfig),
+ new TestServerInventoryView(walker.getSegments()),
Review comment:
i didn't look carefully, it's in
`/druid/sql/src/test/java/org/apache/druid/sql/calcite/util`, I think we can
keep it there, as it's mostly being used by tests. Will use a mock in this
benchmark instead of `TestServerInventoryView`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
