surekhasaharan commented on a change in pull request #6094: Introduce 
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r221496460
 
 

 ##########
 File path: 
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
 ##########
 @@ -517,10 +532,9 @@ private DruidTable buildDruidTable(final String 
dataSource)
     return queryLifecycleFactory.factorize().runSimple(segmentMetadataQuery, 
authenticationResult, null);
   }
 
-  private static RowSignature analysisToRowSignature(final SegmentAnalysis 
analysis)
+  private static Pair<RowSignature, Long> analysisToRowSignature(final 
SegmentAnalysis analysis)
 
 Review comment:
   yeah, that seems better, reverted the change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to