gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r221660862
########## File path: processing/src/main/java/org/apache/druid/query/GroupByMergedQueryRunner.java ########## @@ -114,10 +113,10 @@ public Void call() { try { if (bySegment) { - input.run(threadSafeQueryPlus, responseContext) + input.run(queryPlus.withQueryMetricsCopied(), responseContext) Review comment: Yes, it could happen if the client of QueryMetrics forgot to emit. But I think the previous approach has the same problem. And this kind of bugs could be easily found and fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org