surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r223265869
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -539,7 +553,18 @@ private static RowSignature analysisToRowSignature(final
SegmentAnalysis analysi
rowSignatureBuilder.add(entry.getKey(), valueType);
}
-
return rowSignatureBuilder.build();
}
+
+ // note this is a mutable map accessed only by SystemSchema
Review comment:
this comment is obsolete now, this method returned `segmentMetadataInfo`
before which is changing in this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
