jihoonson commented on a change in pull request #6414: Period
load/drop/broadcast rules should include the future by default
URL: https://github.com/apache/incubator-druid/pull/6414#discussion_r226140999
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/rules/PeriodBroadcastDistributionRule.java
##########
@@ -94,7 +104,9 @@ public boolean equals(Object o)
if (!Objects.equals(period, that.period)) {
return false;
}
-
+ if (!Objects.equals(includeFuture, that.includeFuture)) {
Review comment:
`includeFuture` can't be null. `if (includeFuture != that.includeFuture)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
