jihoonson commented on issue #6336: update insert pending segments logic to synchronous URL: https://github.com/apache/incubator-druid/pull/6336#issuecomment-430841806 @FaxianZhao thanks for the fix! You don't have to rebase any comments in most cases. Once you commit, it's fine to leave them as they are. The failing unit tests seem legit. Please check it. ``` java.lang.RuntimeException: java.lang.NullPointerException: actionOnInvalidLocks at org.apache.druid.indexing.common.actions.SegmentAllocateAction.tryAllocate(SegmentAllocateAction.java:292) at org.apache.druid.indexing.common.actions.SegmentAllocateAction.tryAllocateSubsequentSegment(SegmentAllocateAction.java:248) at org.apache.druid.indexing.common.actions.SegmentAllocateAction.perform(SegmentAllocateAction.java:171) at org.apache.druid.indexing.common.actions.SegmentAllocateActionTest.allocate(SegmentAllocateActionTest.java:720) at org.apache.druid.indexing.common.actions.SegmentAllocateActionTest.testCannotAddToExistingSingleDimensionShardSpecs(SegmentAllocateActionTest.java:670) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121) Caused by: java.lang.NullPointerException: actionOnInvalidLocks at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:229) at org.apache.druid.indexing.overlord.CriticalAction.<init>(CriticalAction.java:48) at org.apache.druid.indexing.overlord.CriticalAction.<init>(CriticalAction.java:40) at org.apache.druid.indexing.overlord.CriticalAction$Builder.build(CriticalAction.java:80) at org.apache.druid.indexing.common.actions.SegmentAllocateAction.tryAllocate(SegmentAllocateAction.java:288) ... 32 more ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
