samarthjain commented on a change in pull request #6504: Remove unused code
URL: https://github.com/apache/incubator-druid/pull/6504#discussion_r227989434
##########
File path:
processing/src/test/java/org/apache/druid/query/groupby/NestedQueryPushDownTest.java
##########
@@ -394,27 +394,26 @@ public void testSimpleDoubleAggregation()
.builder()
.setDataSource("blah")
.setQuerySegmentSpec(intervalSpec)
- .setDimensions(Lists.newArrayList(
+ .setDimensions(
new DefaultDimensionSpec("dimA", "dimA"),
Review comment:
Well that is unfortunate. Without code editors being able to do this
automatically, adhering to this coding guideline makes it painful. I changed
formatting at a few places, but considering I had to do it manually, I am sure
I may have missed some. Having said that, I see tons of place in the existing
code base where this coding guideline hasn't been followed (likely because
Intellij doesn't do the un-breaking).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
