jihoonson commented on a change in pull request #6510: Added support for
filtering by unused parameter
URL: https://github.com/apache/incubator-druid/pull/6510#discussion_r230967910
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/MetadataTaskStorage.java
##########
@@ -208,15 +208,15 @@ public void setStatus(final TaskStatus status)
}
@Override
- public List<TaskInfo<Task, TaskStatus>> getRecentlyFinishedTaskInfo(
+ public List<TaskInfo<Task, TaskStatus>>
getFinishedTaskInfoByCreatedTimeDuration(
@Nullable Integer maxTaskStatuses,
- @Nullable Duration duration,
+ @Nullable Duration createdTimeDuration,
Review comment:
`createdTimeDuration` sounds less intuitive to me. How about
`durationBeforeNow`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
