drcrallen commented on a change in pull request #6370: Introduce SegmentId class
URL: https://github.com/apache/incubator-druid/pull/6370#discussion_r243674404
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/index/YeOldePlumberSchool.java
##########
@@ -113,7 +113,7 @@ public Plumber findPlumber(
);
// Temporary directory to hold spilled segments.
- final File persistDir = new File(tmpSegmentDir,
theSink.getSegment().getIdentifier());
+ final File persistDir = new File(tmpSegmentDir,
theSink.getSegment().getId().toString());
Review comment:
This is an unfortunate legacy effect. It would be nice if we didn't inject
segment ids as file names. That can cause odd problems depending on the file
system. Probably out of scope for this PR though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
