leventov commented on a change in pull request #6370: Introduce SegmentId class
URL: https://github.com/apache/incubator-druid/pull/6370#discussion_r245599255
##########
File path:
processing/src/main/java/org/apache/druid/query/metadata/metadata/SegmentAnalysis.java
##########
@@ -173,10 +181,6 @@ public int hashCode()
@Override
public int compareTo(SegmentAnalysis rhs)
{
- // Nulls first
- if (rhs == null) {
Review comment:
It doesn't work inside `compareTo()`, because obviously not symmetric. If
somebody needs null handling then should use
Comparators.nullsFirst()/nullsLast()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
