surekhasaharan edited a comment on issue #6901: Introduce published segment cache in broker URL: https://github.com/apache/incubator-druid/pull/6901#issuecomment-458245549 > > Heads up, I very briefly experimented with interning data segments back in #3286 but had to back it out because real-time nodes publish with a size of 0, which makes the segment size calculations all break. > > Thanks @drcrallen This issue can indeed happen, I looked at the trail of issues surrounding #3286, I am thinking of addressing #3287 before this PR to avoid incorrect segment sizes. The size issue is resolved with my latest commit. Changed the `DataSegmentInterner` to not rely on the `DataSegment#equals`, it instead uses separate interners for historical and realtime segments.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org