kamaci commented on a change in pull request #6931: Since notify might not wake up the right thread, notifyAll should be used instead. URL: https://github.com/apache/incubator-druid/pull/6931#discussion_r252586942
########## File path: extensions-contrib/druid-rocketmq/src/main/java/org/apache/druid/firehose/rocketmq/RocketMQFirehoseFactory.java ########## @@ -404,7 +404,7 @@ public void putRequest(final DruidPullRequest request) this.requestsWrite.add(request); if (!hasNotified) { hasNotified = true; - notify(); + notifyAll(); Review comment: 👍 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org