leventov commented on a change in pull request #6939: Throw caught exception.
URL: https://github.com/apache/incubator-druid/pull/6939#discussion_r255031763
##########
File path: codestyle/checkstyle.xml
##########
@@ -204,6 +204,12 @@
<property name="message" value="Use
org.apache.druid.server.http.HttpMediaType#TEXT_PLAIN_UTF8 instead"/>
</module>
+ <module name="Regexp">
+ <property name="format" value='^((?!throw|=).)* Throwables.propagate\('/>
+ <property name="illegalPattern" value="true"/>
+ <property name="message" value="Throw caught exception"/>
Review comment:
If you are asking how to replace `Throwables.propagate()`, see [What to
do](https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate#what-to-do)
section in the article.
I suggest the following algorithm:
1. Try to replace `Throwables.propagate(e)` with `throw e`. If it's fine
and javac doesn't complain, then fine. It's also likely that IDE will then
highlight possible simplification of code, like `catch (SomeException e) {
throw e; }` is pointless and could be removed entirely.
2. If `throw e` is not fine (IDE highlights something with red), replace it
with `throw new RuntimeException(e)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
