glasser commented on issue #7089: ParallelIndexSubTask: support ingestSegment in delegating factories URL: https://github.com/apache/incubator-druid/pull/7089#issuecomment-465045135 Note that this PR is integration-tested by ITIndexerTest. Please note two FIXME comments in the PR. My intention is to squash the two commits of the PR together (and keep the PR description as the commit message). I thought reviewers might like to see my initial attempt which injected a SegmentLoaderFactory instead of directly creating a SegmentLoaderLocalCacheManager. That commit led to this error in ITIndexerTest: ``` Can not construct instance of org.apache.druid.indexing.firehose.IngestSegmentFirehoseFactory, problem: Unable to provision, see the following errors: 1) druid.segmentCache.locations - may not be empty at org.apache.druid.guice.JsonConfigProvider.bind(JsonConfigProvider.java:151) (via modules: com.google.inject.util.Modules$OverrideModule -> com.google.inject.util.Modules$OverrideModule -> org.apache.druid.guice.StorageNodeModule) at org.apache.druid.guice.JsonConfigProvider.bind(JsonConfigProvider.java:151) (via modules: com.google.inject.util.Modules$OverrideModule -> com.google.inject.util.Modules$OverrideModule -> org.apache.druid.guice.StorageNodeModule) while locating com.google.common.base.Supplier<org.apache.druid.segment.loading.SegmentLoaderConfig> at org.apache.druid.guice.ConfigProvider.bind(JsonConfigProvider.java:152) (via modules: com.google.inject.util.Modules$OverrideModule -> com.google.inject.util.Modules$OverrideModule -> org.apache.druid.guice.StorageNodeModule) while locating org.apache.druid.segment.loading.SegmentLoaderConfig for the 2nd parameter of org.apache.druid.segment.loading.SegmentLoaderLocalCacheManager.<init>(SegmentLoaderLocalCacheManager.java:67) while locating org.apache.druid.segment.loading.SegmentLoaderLocalCacheManager for the 1st parameter of org.apache.druid.indexing.common.SegmentLoaderFactory.<init>(SegmentLoaderFactory.java:41) while locating org.apache.druid.indexing.common.SegmentLoaderFactory 1 error at [Source: HttpInputOverHTTP@3eff14c3[c=1623,q=0,[0]=null,s=STREAM]; line: 47, column: 13] (through reference chain: org.apache.druid.indexing.common.task.IndexTask["spec"]->org.apache.druid.indexing.common.task.IndexIngestionSpec["ioConfig"]->org.apache.druid.indexing.common.task.IndexIOConfig["firehose"]) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
