kgyrtkirk commented on code in PR #17699:
URL: https://github.com/apache/druid/pull/17699#discussion_r1946492699
##########
server/src/test/java/org/apache/druid/server/TestClusterQuerySegmentWalker.java:
##########
@@ -74,15 +76,18 @@
*/
public class TestClusterQuerySegmentWalker implements QuerySegmentWalker
{
+ public static final String TIMELINES_KEY = "timelines";
+
private final Map<String, VersionedIntervalTimeline<String,
ReferenceCountingSegment>> timelines;
private final QueryRunnerFactoryConglomerate conglomerate;
@Nullable
private final QueryScheduler scheduler;
private final GroupByQueryConfig groupByQueryConfig;
private final EtagProvider etagProvider;
+ @Inject
TestClusterQuerySegmentWalker(
- Map<String, VersionedIntervalTimeline<String, ReferenceCountingSegment>>
timelines,
+ @Named(TIMELINES_KEY) Map<String, VersionedIntervalTimeline<String,
ReferenceCountingSegment>> timelines,
Review Comment:
in those static methods this map was used to back-communicate...didn't
wanted to make them much different ; so just added this `Named` tag so it will
be less likely that it surprises someone :)
by using the constant as the name I was thinking that people interested in
its usage could look it up if needed.
I guess sometimes later this will be dropped and probably
`TestTimelineServerView` could take its place?
butfor now I've packed this `Map` into a `TestSegmentsBroker`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
