kfaraz commented on code in PR #17653:
URL: https://github.com/apache/druid/pull/17653#discussion_r1947445147
##########
services/src/main/java/org/apache/druid/cli/CliOverlord.java:
##########
@@ -228,6 +230,10 @@ public void configure(Binder binder)
JsonConfigProvider.bind(binder, "druid.indexer.task.default",
DefaultTaskConfig.class);
binder.bind(RetryPolicyFactory.class).in(LazySingleton.class);
+ binder.bind(SegmentMetadataCache.class)
Review Comment:
Ideally, the other server types shouldn't need the binding at all.
But we have this dep graph:
`CoreInjectorBuilder` -> `DerbyMetadataStorageModule` ->
`SQLMetadataStorageModule` -> `SqlSegmentMetadataTransactionFactory` (required
for `IndexerSQLMetadataStorageCoordinator`) -> `SegmentMetadataCache`.
`CoreInjectorBuilder` should not even load `DerbyMetadataStorageModule`, it
should be loaded only in `CliOverlord` and `CliCoordinator`. But I decided to
make this change in a separate PR so that I could test it out properly, just to
be on the safe side.
Please let me know if you think I should include it in this PR itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
