cryptoe commented on code in PR #17735:
URL: https://github.com/apache/druid/pull/17735#discussion_r1972909678
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/data/input/kafka/KafkaTopicPartition.java:
##########
@@ -133,6 +133,12 @@ public String toString()
'}';
}
+ @Override
+ public int compareTo(KafkaTopicPartition o)
+ {
+ return Integer.compare(partition, o.partition);
Review Comment:
Wont this throw off sorting.
Like we would want first the name and then the partition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
