nozjkoitop commented on code in PR #16889:
URL: https://github.com/apache/druid/pull/16889#discussion_r1981543252
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/ImmutableWorkerInfo.java:
##########
@@ -57,6 +61,7 @@ public ImmutableWorkerInfo(
@JsonProperty("worker") Worker worker,
@JsonProperty("currCapacityUsed") int currCapacityUsed,
@JsonProperty("currParallelIndexCapacityUsed") int
currParallelIndexCapacityUsed,
+ @JsonProperty("currCapacityUsedByTaskType") Map<String, Integer>
currCapacityUsedByTaskType,
Review Comment:
It is immutable. incrementTypeSpecificCapacity doesn't change the fields.
This typeSpecificCapacity is managed exactly like parallelIndexCapacityUsed,
which is `immutableWorker.getCurrParallelIndexCapacityUsed() +
parallelIndexTaskCapacity` in ImmutableWorkerInfo constructor arguments, but
here the incremented value is created in ImmutableWorkerInfo itself. Wrt
decrement, I dont see any for currParallelIndexCapacityUsed and
currCapacityUsed either, if I'm not mistaken it's managed by Provisioning
Strategy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
