clintropolis commented on code in PR #17776:
URL: https://github.com/apache/druid/pull/17776#discussion_r1981890837
##########
processing/src/main/java/org/apache/druid/guice/StartupInjectorBuilder.java:
##########
@@ -165,6 +166,48 @@ public void validate()
docsLink
);
}
+
+ validateRemovedProcessingConfigs();
+ }
+
+ private void validateRemovedProcessingConfigs()
+ {
+ checkOldConfigAndThrow(
+ "druid.processing.merge.task.initialYieldNumRows",
+ "druid.processing.merge.initialYieldNumRows"
+ );
+ checkOldConfigAndThrow(
+ "druid.processing.merge.task.targetRunTimeMillis",
+ "druid.processing.merge.targetRunTimeMillis"
+ );
+ checkOldConfigAndThrow(
+ "druid.processing.merge.task.smallBatchNumRows",
+ "druid.processing.merge.smallBatchNumRows"
+ );
+
+ checkOldConfigAndThrow(
+ "druid.processing.merge.pool.awaitShutdownMillis",
+ "druid.processing.merge.awaitShutdownMillis"
+ );
+ checkOldConfigAndThrow(
+ "druid.processing.merge.pool.parallelism",
+ "druid.processing.merge.parallelism"
+ );
+ checkOldConfigAndThrow(
+ "druid.processing.merge.pool.defaultMaxQueryParallelism",
+ "druid.processing.merge.defaultMaxQueryParallelism"
+ );
+ }
+
+ private void checkOldConfigAndThrow(String oldPath, String newPath)
+ {
+ if (properties.getProperty(oldPath) != null) {
+ throw InvalidInput.exception(
Review Comment:
nit: maybe these should throw `ISE` to be consistent with the other
exceptions thrown by `PropertiesValidator`? The reason we went with `ISE` is
because `DruidException` doesn't really do anything useful here because it has
a bunch of stuff mainly aimed at API responses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
