github-advanced-security[bot] commented on code in PR #17775:
URL: https://github.com/apache/druid/pull/17775#discussion_r2004988210
##########
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java:
##########
@@ -179,14 +210,21 @@
@Override
public void removeSegment(DataSegment segment, @Nullable
DataSegmentChangeCallback callback)
{
- removeSegment(segment, callback, true);
+ removeSegment(segment, callback, true, SegmentLoadingMode.NORMAL);
+ }
+
+ @VisibleForTesting
+ void removeSegment(DataSegment segment, @Nullable DataSegmentChangeCallback
callback, boolean scheduleDrop)
+ {
+ removeSegment(segment, callback, scheduleDrop, SegmentLoadingMode.NORMAL);
}
@VisibleForTesting
void removeSegment(
final DataSegment segment,
@Nullable final DataSegmentChangeCallback callback,
- final boolean scheduleDrop
+ final boolean scheduleDrop,
+ final SegmentLoadingMode segmentLoadingMode
Review Comment:
## Useless parameter
The parameter 'segmentLoadingMode' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8758)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
