kfaraz commented on code in PR #17775:
URL: https://github.com/apache/druid/pull/17775#discussion_r2007159634
##########
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java:
##########
@@ -100,13 +119,20 @@ public SegmentLoadDropHandler(
SegmentLoaderConfig config,
DataSegmentAnnouncer announcer,
SegmentManager segmentManager,
- ScheduledExecutorService exec
+ ThreadPoolExecutor standardExec,
+ ThreadPoolExecutor turboExec,
+ ScheduledExecutorService scheduledExecutorService
)
{
this.config = config;
this.announcer = announcer;
this.segmentManager = segmentManager;
- this.exec = exec;
+ this.standardExec = standardExec;
+ this.turboExec = turboExec;
+ this.scheduledExecutorService = scheduledExecutorService;
+
+ this.standardExec.allowCoreThreadTimeOut(true);
+ this.turboExec.allowCoreThreadTimeOut(true);
Review Comment:
Hmm, I see. In that case, let's just use a `ThreadPoolExecutor loadExec` and
a `ScheduledExecutorService dropExec`. The `dropExec` can have a fixed small
number of threads, say 2 or 5, since drops are fast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
