kfaraz commented on code in PR #17785: URL: https://github.com/apache/druid/pull/17785#discussion_r2013067197
########## indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/OverlordDataSourcesResource.java: ########## @@ -66,19 +67,22 @@ public class OverlordDataSourcesResource private static final Logger log = new Logger(OverlordDataSourcesResource.class); private final SegmentsMetadataManager segmentsMetadataManager; + private final IndexerMetadataStorageCoordinator metadataStorageCoordinator; Review Comment: Yes, @gianm , I plan to get rid of `SqlSegmentsMetadataManager` from the Overlord completely. Coordinator will continue to use it for the time being, but eventually we might just get rid of it altogether. - The usage of `SqlSegmentsMetadataManager` by `OverlordCompactionScheduler` does matter for performance because of the timeline and caching reasons as you guessed, but I should be able to resolve this soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
