gianm commented on PR #17784: URL: https://github.com/apache/druid/pull/17784#issuecomment-2768498695
@applike-ss thank you for your contribution! I've updated the PR branch to: - merge `master`, which includes a fix for the twitter repo (#17797) - restore the prior styling in the file `extensions-core/kubernetes-overlord-extensions/src/test/java/org/apache/druid/k8s/overlord/taskadapter/K8sTaskAdapterTest.java`, since the new styling in this branch was tripping style checks - add a `resources` section to the expected output for the new test `testProbesRemoved`. It is added by the `K8sTaskAdapter`. As to the `ExprListenerImpl` errors you got when trying to run locally, FWIW, I think that is something that can happen in IntelliJ because it doesn't know how to generate certain sources. Running a commandline build `mvn package -DskipTests` once should clear that up. That command will also run the static checks, style checks, etc. Anyway, I don't think you need to do that right now, because hopefully the stuff I just pushed to the PR branch will fix the issues reported by CI. I'm just writing this as FYI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
