adarshsanjeev commented on code in PR #17834:
URL: https://github.com/apache/druid/pull/17834#discussion_r2022331530
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/CompactionScheduler.java:
##########
@@ -44,24 +44,46 @@
*/
public interface CompactionScheduler
{
- void start();
+ void becomeLeader();
- void stop();
+ void stopBeingLeader();
Review Comment:
`stop()` and `start()` seemed to better names from my understanding.
`stopBeingLeader()` seems to be tying in the reason for why the scheduler is
stopping, but that doesn't need to be part of the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
