GWphua opened a new pull request, #17898: URL: https://github.com/apache/druid/pull/17898
Related to #17738 , #17749 This PR should be backported to Druid 33. ### Description #### Add documentations that address concerns when changing related configurations Link to conversation: https://github.com/apache/druid/pull/17738#issuecomment-2783647766 https://github.com/apache/druid/pull/17749#issuecomment-2783599925 Added documentation that explains the need to stop all running tasks when configuring `druid.indexer.runner.k8sTaskPodNamePrefix` and `druid.indexer.runner.overlordNamespace` #### Fixed Rolling Upgrade issue when using PodTemplate Currently, when doing a rolling upgrade using pod templates, while not specifying `druid.indexer.runner.overlordNamespace`, there's an issue of rolling upgrade causing the Overlord to fail to detect some tasks or detect some extra tasks and then error out. I have changed the code + added Unit Tests to check that this problem will no longer exist when doing rolling upgrades. <hr> ##### Key changed/added classes in this PR * `k8s-jobs.md` * `KubernetesPeonClient` * `KubernetesPeonClientTest` <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [x] been self-reiewed. - [x] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. (Not needed if same release) - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
