cryptoe commented on code in PR #17903:
URL: https://github.com/apache/druid/pull/17903#discussion_r2054456092
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java:
##########
@@ -64,7 +65,8 @@ public LagBasedAutoScalerConfig(
@Nullable @JsonProperty("scaleOutStep") Integer scaleOutStep,
@Nullable @JsonProperty("enableTaskAutoScaler") Boolean
enableTaskAutoScaler,
@Nullable @JsonProperty("minTriggerScaleActionFrequencyMillis") Long
minTriggerScaleActionFrequencyMillis,
- @Nullable @JsonProperty("lagAggregate") AggregateFunction
lagAggregate
+ @Nullable @JsonProperty("lagAggregate") AggregateFunction
lagAggregate,
+ @Nullable @JsonProperty("useProportionalScaler") Boolean
useProportionalScaler
Review Comment:
I think the behavior, scaling based on partition sizes so that each task has
same input partition seem the correct behavior. We can turn this config on by
default and then remove it in future releases.
The backdoor for a few releases would be turning it off via supervisor
config.
So that is what I was thinking. Wanted to check if it answers your question ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
