cecemei commented on code in PR #17943:
URL: https://github.com/apache/druid/pull/17943#discussion_r2060724696
##########
processing/src/main/java/org/apache/druid/segment/CompleteSegment.java:
##########
@@ -39,6 +40,9 @@ public class CompleteSegment implements Closeable
public CompleteSegment(@Nullable DataSegment dataSegment, Segment segment)
{
this.dataSegment = dataSegment;
+ if (segment instanceof SegmentReference) {
Review Comment:
Actually reverted the change in `CompleteSegment`, since this check for
`SegmentReference` is kinda strange too.
##########
processing/src/main/java/org/apache/druid/segment/ReferenceCountingSegment.java:
##########
@@ -79,6 +80,9 @@ protected ReferenceCountingSegment(
)
{
super(baseSegment);
+ if (baseSegment instanceof SegmentReference) {
+ throw DruidException.defensive("Cannot use a SegmentReference as
baseSegment for a ReferenceCountingSegment");
Review Comment:
updated this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
