kgyrtkirk commented on code in PR #17861: URL: https://github.com/apache/druid/pull/17861#discussion_r2069173795
########## quidem-ut/src/test/quidem/org.apache.druid.quidem.QTest/qaAggFuncs/array_agg_double_test001.all.iq: ########## @@ -0,0 +1,537 @@ +!set dartQueryId 00000000-0000-0000-0000-000000000000 +!set useApproximateCountDistinct false +!use druidtest://?componentSupplier=AllDruidEnginesComponentSupplier&datasets=sql/src/test/quidem/qatests/qaAggFuncs +!set outputformat mysql +SELECT count(*) cnt +FROM test_agg_funcs; ++-----+ +| cnt | ++-----+ +| 18 | ++-----+ +(1 row) + +!ok + +#------------------------------------------------------------------------- +# TESTCASE: test001 TEST_ID: A01 TYPE: POSITIVE TEST +#------------------------------------------------------------------------- +SELECT count(*) cnt +FROM + (SELECT array_agg(111.1111111) AS col) +WHERE NOT array_contains(col, 99999) + OR col IS NULL; ++-----+ +| cnt | ++-----+ +| 1 | ++-----+ +(1 row) + +!ok + +#------------------------------------------------------------------------- +# TESTCASE: test001 TEST_ID: A02 TYPE: POSITIVE TEST Review Comment: I just don't want to give a chance to the advent of contradicting details in the future: say we have something like this: ``` # TESTCASE ... NEGATIVE TEST select something; !error ``` if in a week or so the expectation changes but the `TYPE` may not be updated as its just comment; so we could end up with: ``` # TESTCASE ... NEGATIVE TEST select something; !ok ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
