kfaraz commented on code in PR #17980:
URL: https://github.com/apache/druid/pull/17980#discussion_r2079529359
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -284,6 +284,24 @@ public String getBaseSequenceName()
{
return baseSequenceName;
}
+
+ @Override
+ public String toString()
+ {
+ return "TaskGroup{" +
+ "groupId=" + groupId +
+ ", startingSequences=" + startingSequences +
+ ", unfilteredStartingSequencesForSequenceName=" +
unfilteredStartingSequencesForSequenceName +
+ ", tasks=" + tasks +
+ ", minimumMessageTime=" + minimumMessageTime +
+ ", maximumMessageTime=" + maximumMessageTime +
+ ", exclusiveStartSequenceNumberPartitions=" +
exclusiveStartSequenceNumberPartitions +
+ ", checkpointSequences=" + checkpointSequences +
+ ", baseSequenceName='" + baseSequenceName + '\'' +
+ ", completionTimeout=" + completionTimeout +
+ ", handoffEarly=" + handoffEarly +
+ '}';
Review Comment:
Similarly, the `TaskData.toString()` should stop including the
`checkpointSequences` field to make the log messages cleaner.
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -284,6 +284,24 @@ public String getBaseSequenceName()
{
return baseSequenceName;
}
+
+ @Override
+ public String toString()
+ {
+ return "TaskGroup{" +
+ "groupId=" + groupId +
+ ", startingSequences=" + startingSequences +
+ ", unfilteredStartingSequencesForSequenceName=" +
unfilteredStartingSequencesForSequenceName +
+ ", tasks=" + tasks +
+ ", minimumMessageTime=" + minimumMessageTime +
+ ", maximumMessageTime=" + maximumMessageTime +
+ ", exclusiveStartSequenceNumberPartitions=" +
exclusiveStartSequenceNumberPartitions +
+ ", checkpointSequences=" + checkpointSequences +
+ ", baseSequenceName='" + baseSequenceName + '\'' +
+ ", completionTimeout=" + completionTimeout +
+ ", handoffEarly=" + handoffEarly +
+ '}';
Review Comment:
I think just including the fields `groupId` and `tasks` might be more useful
for logging. The other information would make the messages too verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
