This is an automated email from the ASF dual-hosted git repository.
karan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new d306ba9b13d Better logging in the overlord. (#17980)
d306ba9b13d is described below
commit d306ba9b13d047734d1f22ccedd04dec7bd6a05d
Author: Karan Kumar <[email protected]>
AuthorDate: Mon May 12 16:12:39 2025 +0530
Better logging in the overlord. (#17980)
* Better logging in the overlord.
* Removing some fields.
---
.../seekablestream/supervisor/SeekableStreamSupervisor.java | 11 ++++++++++-
.../org/apache/druid/java/util/common/logger/Logger.java | 13 +++++++++++++
.../metadata/IndexerSQLMetadataStorageCoordinator.java | 2 +-
3 files changed, 24 insertions(+), 2 deletions(-)
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
b/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
index 9c6fb46e82e..6aacfd07333 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
@@ -284,6 +284,15 @@ public abstract class
SeekableStreamSupervisor<PartitionIdType, SequenceOffsetTy
{
return baseSequenceName;
}
+
+ @Override
+ public String toString()
+ {
+ return "TaskGroup{" +
+ "groupId=" + groupId +
+ ", tasks=" + tasks +
+ '}';
+ }
}
private class TaskData
@@ -462,7 +471,7 @@ public abstract class
SeekableStreamSupervisor<PartitionIdType, SequenceOffsetTy
log.info(
"Skipping DynamicAllocationTasksNotice execution for
datasource [%s] because following tasks are pending [%s]",
dataSource,
- pendingCompletionTaskGroups
+ list
);
return;
}
diff --git
a/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java
b/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java
index b1f21c3d9e1..1c1285c8b0c 100644
---
a/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java
+++
b/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java
@@ -255,6 +255,19 @@ public class Logger
logSegments(this::error, segments, preamble);
}
+ /**
+ * Logs error exception first and then logs the segments
+ */
+ public void errorSegments(
+ Throwable throwable,
+ @Nullable final Collection<DataSegment> segments,
+ String preamble
+ )
+ {
+ log.error(preamble, throwable);
+ logSegments(this::error, segments, preamble);
+ }
+
public boolean isTraceEnabled()
{
return log.isTraceEnabled();
diff --git
a/server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
b/server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
index c93ca2516bd..e4f84dab233 100644
---
a/server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
+++
b/server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
@@ -1705,7 +1705,7 @@ public class IndexerSQLMetadataStorageCoordinator
implements IndexerMetadataStor
}
}
catch (Exception e) {
- log.errorSegments(segments, "Exception inserting segments");
+ log.errorSegments(e, segments, "Exception inserting segments");
throw e;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
