cecemei commented on code in PR #18005:
URL: https://github.com/apache/druid/pull/18005#discussion_r2093504849
##########
processing/src/main/java/org/apache/druid/segment/join/HashJoinSegment.java:
##########
@@ -65,19 +65,22 @@ public class HashJoinSegment implements SegmentReference
* @param joinFilterPreAnalysis Pre-analysis for the query we expect to run
on this segment
*/
public HashJoinSegment(
Review Comment:
Maybe it's worth putting some comments to explain the referenceCloseable
comes from JoinableClause reference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
