a2l007 opened a new pull request, #18016:
URL: https://github.com/apache/druid/pull/18016

   Fixes #18015.
   
   
   ### Description
   Fixes an issue where attempting to load iceberg tables from an AWS Glue 
catalog fails with ClassNotFound exceptions.
   AWS Glue catalog internally uses 
[DynConstructors](https://iceberg.apache.org/javadoc/1.6.1/org/apache/iceberg/common/DynConstructors.html)
 which uses reflection to locate certain Glue-related classes from the 
iceberg-aws dependency. This uses the [current thread context 
classloader](https://github.com/apache/iceberg/blob/apache-iceberg-1.6.1/common/src/main/java/org/apache/iceberg/common/DynConstructors.java#L119)
 to locate it but these classes are only available on the application 
classloader.
   This PR does a context classloader switch to fix the issue.
   
   
   #### Release note
   Fixes an issue where loading Iceberg tables from the AWS Glue Catalog could 
fail due to ClassNotFoundException exceptions.
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to