clintropolis commented on code in PR #18005:
URL: https://github.com/apache/druid/pull/18005#discussion_r2105672505
##########
processing/src/main/java/org/apache/druid/segment/join/table/BroadcastSegmentIndexedTable.java:
##########
@@ -254,8 +254,11 @@ public void close()
}
@Override
- public Optional<Closeable> acquireReferences()
+ public Optional<Closeable> acquireReference()
{
- return Optional.empty();
+ // this is wrong, we should have a reference to the reference counted
segment instead of the direct segment so that
Review Comment:
wrong prior to this patch, the issues that could happen is that because the
joinable doesn't grab a reference to the underlying segment, there is no guard
on the segment being dropped during processing. This is mainly for integration
tests and isn't really documented so is probably not a huge problem in
practice, as a broadcast segment it will only be dropped if it is updated with
a newer version.
##########
processing/src/main/java/org/apache/druid/segment/SegmentMapFunction.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.segment;
+
+import java.util.Optional;
+import java.util.function.Function;
+
+/**
+ * Functional interface that captures the process of acquiring a {@link
Segment} from a
+ * {@link ReferenceCountedObjectProvider<Segment>} and performing any
transformations done on top of this leaf {@link Segment}
+ * before it is available to query processing engines.
+ * <p>
+ * The {@link Segment} returned by this method, if present, must always be
closed to return the reference to the base
+ * {@link ReferenceCountedObjectProvider<Segment>} that it came from.
+ */
+@FunctionalInterface
+public interface SegmentMapFunction extends
Function<ReferenceCountedObjectProvider<Segment>, Optional<Segment>>
+{
+ /**
+ * {@link SegmentMapFunction} that acuires a {@link Segment} from the {@link
ReferenceCountedObjectProvider<Segment>}
+ */
+ SegmentMapFunction IDENTITY =
ReferenceCountedObjectProvider::acquireReference;
+
+ /**
+ * Returns a {@link SegmentMapFunction} that calls {@link
ReferenceCountedObjectProvider#acquireReference()} and then
+ * applies the function to the resulting {@link Segment}, if present
+ */
+ static SegmentMapFunction map(Function<Segment, Segment> mapFn)
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
