kfaraz commented on code in PR #18032: URL: https://github.com/apache/druid/pull/18032#discussion_r2106184984
########## server/src/main/java/org/apache/druid/server/metrics/TaskMetricKey.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.metrics; + +import java.util.Objects; + +/** + A hashable, extendible key used for aggregating useful metrics on tasks. +*/ +public class TaskMetricKey Review Comment: I don't think we need this new class. There is an existing class [RowKey](https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/server/coordinator/stats/RowKey.java) which is more generic. The `RowKey` is typically used in `CoordinatorRunStats` which I had plans to generalize for all of Druid and not keep limited to the Coordinator. The `CoordinatorRunStats` anyway happens to be already in use in `TaskCountStatsMonitor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
