gianm commented on PR #18028: URL: https://github.com/apache/druid/pull/18028#issuecomment-2922774947
@kfaraz There is a follow up item listed in the description to limit logging to deletion failures/skips only: > While this is okay for a normal kill task, it becomes too verbose when running embedded kill tasks on the Overlord. > For embedded kill tasks, we should log only warnings or errors for paths that could not be deleted or were skipped for some reason. There should be _some_ message that is logged at INFO level for each segment that is deleted. Deleting a segment is a destructive operation that in some situations is not undoable. Operators need some logs when that happens, for situations where they wonder what happened to their segment files. Ideally, there is exactly one message logged at INFO level for each segment (not zero, not more than one). Ideally that one message has both the segment ID and the storage location (S3/GCS/Azure/etc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
