jtuglu-netflix commented on code in PR #18045: URL: https://github.com/apache/druid/pull/18045#discussion_r2117566500
########## indexing-service/src/main/java/org/apache/druid/indexing/common/TaskStorageDirTracker.java: ########## @@ -259,4 +267,9 @@ public String toString() '}'; } } + + public synchronized long getNumUsedSlots() Review Comment: Any thoughts on blocking other in-flight tasks to read this? I originally had an atomic be incremented/decremented in the same places to avoid taking the exclusive lock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org