kfaraz commented on code in PR #18106:
URL: https://github.com/apache/druid/pull/18106#discussion_r2137924275
##########
server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java:
##########
@@ -500,8 +500,7 @@ private static int
getMaxJettyAcceptorsSelectorsNum(DruidNode druidNode)
private static int getTCPAcceptQueueSize()
{
if (SystemUtils.IS_OS_LINUX) {
- try {
- BufferedReader in =
Files.newBufferedReader(Paths.get("/proc/sys/net/core/somaxconn"));
+ try (BufferedReader in =
Files.newBufferedReader(Paths.get("/proc/sys/net/core/somaxconn")) ) {
Review Comment:
```suggestion
try (BufferedReader in =
Files.newBufferedReader(Paths.get("/proc/sys/net/core/somaxconn"))) {
```
##########
server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java:
##########
@@ -500,8 +500,7 @@ private static int
getMaxJettyAcceptorsSelectorsNum(DruidNode druidNode)
private static int getTCPAcceptQueueSize()
{
if (SystemUtils.IS_OS_LINUX) {
- try {
- BufferedReader in =
Files.newBufferedReader(Paths.get("/proc/sys/net/core/somaxconn"));
+ try (BufferedReader in =
Files.newBufferedReader(Paths.get("/proc/sys/net/core/somaxconn")) ) {
Review Comment:
This caused checkstyle to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
